Details
-
Bug
-
Resolution: Unresolved
-
Minor
-
COmanage Registry 3.2.2 (Oyster Pearl MR2)
-
None
Description
In enrollments using the self-signup system, an OrgIdentity is created early on. This would also apply for account-linking, COU signups, etc.: all cases where an OrgIdentity is already available before saving the petitionerAttributes.
In the CoPetition::petitionerAttributes method, OrgIdentity attributes are only checked to be copied if no OrgIdentity was available beforehand. In that case, all attributes are looped and those marked for copying are copied.
For such enrollments, administrators should not configure OrgIdentity related attributes, but only CoPerson and CoPersonRole attributes, so that the collected data can be saved only on the CoPerson. It can be argued that this case is thus a misconfiguration.
However, users are not informed of this while creating an Enrollment. It can therefor also be argued that if the user adds enrollment attributes and indicates those attributes need to be 'collected for OrgIdentity' and 'copied to CoPerson', that the latter action is executed regardless of the first. I.e.: do not copy the CoPerson attributes only if an OrgIdentity was created, but do that for all cases where we have enrollment attributes that have a 'Copy to CoPerson' indication.
The actual implementation is as simple as moving the respective copy loop outside and below the if block in CoPetition::saveAttributes.
Attachments
Issue Links
- is related to
-
CO-1578 Enrollment Source Invitation Single Org Identity
- Resolved