Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-1004

grouper user data should not be stored in PIT, audits, or change log

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 2.2.0
    • 2.2.0
    • API
    • None

    Description

      Shilen, Im thinking we just stop the attribute value assignments (by specifying attributeDefs to ignore). This way everything is consistent (membership in the group, attribute assignment on the membership, but not the value changes [which cause all the churn]).

      So… I made changes to do this, and the result is we will see GrouperSystem recent activity when new people get onboarded to the UI and start making changes. But once that is done we wont see anything… here is an example. The ones in yellow are the first time Groupersystem made a change. The one is green is after that (nothing about attributes).

      Well, I was looking at the sync PIT and I need to move this from code to config… so I will rework it, but it will look like this: ok?

      More soon (well, later, after fireworks)

      Recent activity
      Added group testGroup0. 2014/07/04 15:39 PM
      Added attribute Grouper user data recent groups to an attribute assignment. 2014/07/04 15:36 PM
      Added group testGroup. 2014/07/04 15:36 PM
      Added attribute Grouper user data to a membership for member GrouperSysAdmin. 2014/07/04 15:36 PM
      Added GrouperSysAdmin as a member of the grouperUiUserData group. 2014/07/04 15:36 PM
      Edited group grouperUiUserData. 2014/07/04 15:36 PM

      From: Shilen Patel shilen
      Sent: Thursday, July 03, 2014 8:44 AM
      To: Chris Hyzer
      Cc: grouper-core
      Subject: Re: [grouper-core] review changes and build

      Right. As far as point in time goes, should we have it so that it doesn't go into the temp change log altogether? That would prevent the point in time audit and also notifications (which may be good too).

      The point in time sync stuff would have to be adjusted as well.

      Let me know if you want me to take care of this part.

      Thanks!

      – Shilen

      From: Chris Hyzer <mchyzer>
      Date: Thursday, July 3, 2014 8:37 AM
      To: Shilen Patel <shilen>
      Cc: "grouper-core" <grouper-core>
      Subject: RE: [grouper-core] review changes and build

      I think we need to look at it, it would cause a lot of pollution in the point in time and audit, even if only for Groupersystem…

      Thanks,
      Chris

      From: Shilen Patel shilen
      Sent: Thursday, July 03, 2014 8:09 AM
      To: Chris Hyzer
      Cc: grouper-core
      Subject: Re: [grouper-core] review changes and build

      Actually, it occurred to me that those audits are being done as GrouperSystem so only GrouperSystem sees all that. So it is probably ok for now.

      Thanks!

      – Shilen

      From: Chris Hyzer <mchyzer>
      Date: Wednesday, July 2, 2014 11:04 PM
      To: Shilen Patel <shilen>
      Cc: "grouper-core" <grouper-core>
      Subject: RE: [grouper-core] review changes and build

      Ugh, this is a problem… seems like these shouldn’t be audited or point in timed, or put in recent activity… or we could just remove the recent activity widget from this release. Thoughts? I will try to look into it…

      Thanks,
      Chris

      From: Shilen Patel shilen
      Sent: Tuesday, July 01, 2014 8:47 AM
      To: Chris Hyzer
      Cc: grouper-core
      Subject: Re: [grouper-core] review changes and build

      Looks good, thanks! Sorry, one more thing. Again, this doesn't have to be looked at now. I don't recall it doing this before so one of the recent changes may have affected this, but there seems to be a lot of "noise" in the recent activity regarding user data. Maybe at some point, those can be filtered out since that's internal stuff.

      Attachments

        Activity

          People

            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: