Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-1413

GroupSave with uuid and no name does not work for new uuids

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.3.1, 2.3.0.patch
    • API
    • None

    Description

      > And if no group is found then don't cause a problem...

      Well, that is how it is documented and how it used to work.

      ----Original Message----
      From: Jim Fox
      Sent: Tuesday, November 08, 2016 3:43 PM
      To: Hyzer, Chris <mchyzer>
      Cc: Grouper Dev <grouper-dev>
      Subject: RE: [grouper-dev] Change to GroupSave in 2.3.0

      I think changing to 'false', and adding a 'if (group!=null)' test would
      fix it.

      Jim

      On Tue, 8 Nov 2016, Hyzer, Chris wrote:

      > Date: Tue, 8 Nov 2016 12:25:49
      > From: "Hyzer, Chris" <mchyzer>
      > To: Jim Fox, Grouper Dev <grouper-dev>
      > Subject: RE: [grouper-dev] Change to GroupSave in 2.3.0
      >
      > So you want it changed to false so it doesn't except?
      >
      > ----Original Message----
      > From: grouper-dev-request On Behalf Of Jim Fox
      > Sent: Tuesday, November 08, 2016 3:18 PM
      > To: Grouper Dev
      > Subject: [grouper-dev] Change to GroupSave in 2.3.0
      >
      >
      >
      > This is about a change to the 'save' method in 2.3.0's GroupSave.java (about line 375)
      >
      > A new segment is added that did not appear in 2.1.2
      >
      > //get from uuid since could be a rename
      > if (StringUtils.isBlank(this.groupNameToEdit) && !StringUtils.isBlank(this.uuid))

      { > Group group = GroupFinder.findByUuid(GrouperSession.staticGrouperSession(), this.uuid, true); > this.groupNameToEdit = group.getName(); > }

      >
      > I'm doing an insert.
      >
      > According to the documentation groupNameToEdit should be null, and uuid should be the uuid of the new group.
      >
      > The call to findByUuid is always going to except.
      >
      > If I set the groupNameToEdit I get through this section. That's contrary to the doc and 2.1.2 usage.
      >
      > The code is from grouper.api-2.3.0.tar.gz, from the downloads page.
      >
      >
      > Jimkk
      >

      Attachments

        Activity

          People

            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Smart Checklist