Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-1420

Member removal from group shows recent activity as GrouperSystem



    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.3.0, 2.4.0
    • 2.3.1, 2.4.0, 2.3.0.patch
    • UI
    • None


      When adding a member to a group, Grouper stores the action in the audit log with ACT_AS_MEMBER_ID field as the logged in user. However, removing a user will store the entry with ACT_AS_MEMBER_ID as the GrouperSystem subject. In both cases, the LOGGED_IN_MEMBER_ID field is the logged in user.

      The recent activity page in the UI queries the act_as_member_id to populate its list of recent actions. Thus, membership adds show up under the user's recent activity, but deletes show up under GrouperSystem's.

      UiV2Group::removeMembers performs member removals as GrouperSystem, with the source code comment "subject has update, so this operation as root in case removing affects the membership". So the audit logging is working as designed. However, it is unexpected for the users, who can see member adds but not deletes.

      Steps to reproduce

      1. Load the sample quick start data
      2. Log in as GrouperSystem
      3. Create test group qsuob:test:AdminAccess
      4. Grant admin to "babe" (Barry Benson)
      5. In tomcat, add "babe" to the tomcat-users.xml if needed
      6. In a different browser, login as "babe"
      7. Go to qsuob:test:AdminAccess
      8. Add bawi (Barry Windsor) as member
      9. Remove Barry Windsor as member
      10. Go to Recent Activity


      • Recent activity for Barry Benson shows: Added Barry Windsor as a member of the AdminAccess group.
      • Recent activity for GrouperSystem shows: Deleted Barry Windsor as a member of the AdminAccess group.




            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            chad.redman@at.internet2.edu Chad Redman (unc.edu)
            0 Vote for this issue
            2 Start watching this issue



              Smart Checklist