Details
-
Bug
-
Resolution: Fixed
-
Minor
-
2.4.0.patch
-
None
Description
There is a NUL (\x0) character at the end of LDAP error messages that are logged by PSPNG. (Well... I did mistakes 
)
Here is a sample of these messages, selected from the output of
cat -v grouper_error.log* | grep -B1 '\^@' |
(NUL appears as "^@")
[org.ldaptive.LdapException@1149801201::resultCode=INVALID_CREDENTIALS, matchedDn=null, responseControls=null, referralURLs=null, messageId=-1, message=javax.naming.AuthenticationException: [LDAP: error code 49 - 80090308: LdapErr: DSID-0C090453, comment: AcceptSecurityContext error, data 775, v3839^@], providerException=javax.naming.AuthenticationException: [LDAP: error code 49 - 80090308: LdapErr: DSID-0C090453, comment: AcceptSecurityContext error, data 775, v3839^@]] |
|
|
[org.ldaptive.LdapException@305151581::resultCode=NO_SUCH_ATTRIBUTE, matchedDn=null, responseControls=null, referralURLs=null, messageId=-1, message=javax.naming.directory.NoSuchAttributeException: [LDAP: error code 16 - 00000057: LdapErr: DSID-0C090F95, comment: Error in attribute conversion operation, data 0, v3839^@]; remaining name 'cn=testgroup,ou=workflow1,ou=bpm-oracle,ou=bpm-poc,ou=application,OU=Grouper,OU=Groups,OU=_UNIGE,DC=isis-klif,DC=unige,DC=ch', providerException=javax.naming.directory.NoSuchAttributeException: [LDAP: error code 16 - 00000057: LdapErr: DSID-0C090F95, comment: Error in attribute conversion operation, data 0, v3839^@]; remaining name 'cn=testgroup,ou=workflow1,ou=bpm-oracle,ou=bpm-poc,ou=application,OU=Grouper,OU=Groups,OU=_UNIGE,DC=isis-klif,DC=unige,DC=ch'] |
|
|
[org.ldaptive.LdapException@1346698318::resultCode=UNWILLING_TO_PERFORM, matchedDn=null, responseControls=null, referralURLs=null, messageId=-1, message=javax.naming.OperationNotSupportedException: [LDAP: error code 53 - 0000054F: SvcErr: DSID-031A1254, problem 5003 (WILL_NOT_PERFORM), data 0 |
^@]; remaining name 'cn=testgroup_all,ou=workflow1,ou=bpm-oracle,ou=bpm-poc,ou=application,ou=grouper,ou=groups,ou=_unige,dc=isis-klif,dc=unige,dc=ch', providerException=javax.naming.OperationNotSupportedException: [LDAP: error code 53 - 0000054F: SvcErr: DSID-031A1254, problem 5003 (WILL_NOT_PERFORM), data 0 |
^@]; remaining name 'cn=testgroup_all,ou=workflow1,ou=bpm-oracle,ou=bpm-poc,ou=application,ou=grouper,ou=groups,ou=_unige,dc=isis-klif,dc=unige,dc=ch'] |
It is not proper to have non printable characters in a log file.
In particular it can cause problems with some tools used to inspect these logs, e.g. if one forgets to add the "-a" option to a "grep" command, the result will be incomplete.
The root cause is probably in the ldaptive library, but nevertheless PSPNG could filter out such spurious NUL character.
Minor, but easy to fix.