Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-3304

external systems buttons should be ajax and not urls

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 2.5.47
    • None
    • None
    • None

    Description

      we have two ways to click buttons:
      1. link

      onclick="if (confirm('${textContainer.textEscapeSingleDouble['grouperExternalSystemConfirmDeleteConfig']}')) { return guiV2link('operation=UiV2ExternalSystem.deleteExternalSystemConfigDetails&externalSystemConfigId=${guiGrouperExternalSystem.grouperExternalSystem.configId}&externalSystemType=${guiGrouperExternalSystem.grouperExternalSystem['class'].name}');" 

      Those are intended for screens that display stuff and puts a URL in the top of browser and browser history for back button etc

      2. ajax

      onclick="ajax('../app/UiV2ExternalSystem.addExternalSystemSubmit', {formIds: 'externalSystemConfigDetails'}); return false;" 

      Those are for the back channel things that actually perform changes

      In the first case, deleting an external system, that is more an ajax thing, so people dont hit the back button and do something they dont intend to do. Also note the confirmation is in javascript, but it wouldnt be with a back button or refresh.

      Attachments

        Activity

          People

            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: