Details
-
Improvement
-
Resolution: Won't Fix
-
Minor
-
2.5.52
-
None
-
None
Description
Please review all of theĀ edu.internet2.middleware.grouper.*Save.java classes.
They all could use a constructor that passes in the session for the object to use.
*Save(GrouperSession session_to_use) {...}
These already support it, but not all of them do.
StemSave, GroupSave
https://github.com/Internet2/grouper/blob/99cd2a64a853fea5c8a672e282115dcb76bee978/grouper/src/grouper/edu/internet2/middleware/grouper/StemSave.java#L135
Likewise the pattern of .assignRunAsRoot(boolean) would be good to also replicate to all of these classes.