Description
So far I've only noticed this problem in the Admin UI, and given that the Admin UI is going away, it may not necessarily be an issue to fix, but I just wanted to at least note it for now.
In the Admin UI, if some operations fail, parts of it may still commit. For example, if you try adding a new group and it fails for some reason at the database, then the temp change log save would still end up being committed.
I think this happens because the transaction is created from GrouperCapableAction and when the failure is caught in SaveGroupAction, nothing is done to tell the caller that there was a failure. So in the end, it commits whatever succeeded at the database (in this case the temp change log insert, since that happens before the save of the group).