Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-1640

Attestation mailer sending to group readers

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 2.3.0.patch
    • 2.4.0, 2.3.0.patch
    • grouperLoader
    • None

    Description

      API patch 81 now checks the user's group/stem privileges, and only lets them mark as reviewed if they have update access. However, the daily mailer job that accumulates email addresses includes group readers as well as admins and updaters. It is probably better to take out the readers, since there is no action they can take on the email they get.

       

      --- a/grouper/src/grouper/edu/internet2/middleware/grouper/app/attestation/GrouperAttestationJob.java
      +++ b/grouper/src/grouper/edu/internet2/middleware/grouper/app/attestation/GrouperAttestationJob.java
      @@ -630,9 +630,8 @@ public class GrouperAttestationJob extends OtherJobBase {
           String[] emailAddresses = null;
           if (StringUtils.isBlank(attestationEmailAddresses)) {

      -      // get the group's admins/updaters/readers
      +      // get the group's admins/updaters
             Set<Subject> groupMembers = group.getAdmins();
      -      groupMembers.addAll(group.getReaders());
             groupMembers.addAll(group.getUpdaters());

             Set<String> addresses = new HashSet<String>();

       

      Attachments

        Activity

          People

            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            chad.redman@at.internet2.edu Chad Redman (unc.edu)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Smart Checklist