UI incorrectly exposes privilege management options

Issue submitted to mailing list by Loris Bennet
Hi,

If a user with the update privilege tries to add a new user and give
that new user the update privilege and error occurs which is defined in
nav.properties:

error.assign-members.assign-privs=Error assigning privileges.

Shouldn't in this case

error.InsufficientPrivilegeException=You do not have sufficient
privileges.

occur?

I assume that this does not happen because of the following exception:

ERROR DoAssignNewMembersAction.grouperExecute(254) - Could not
assign all privileges java.lang.NullPointerException
at
edu.internet2.middleware.grouper.GrouperHelper.assignPrivileges(GrouperHelper.java:932)
at
edu.internet2.middleware.grouper.ui.actions.DoAssignNewMembersAction.grouperExecute(DoAssignNewMembersAction.java:249)

which presumably leads to the rather generic error message.

I notice too that there is also an error:

groups.remove.no-privs.error=Insufficient privileges to remove
members

Wouldn't it make sense to have an error like

groups.add.no-privs.error=Insufficient privileges to add members
with chosen privileges

for the case described above?

regards

Loris