Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-2474

LoaderLog getGroupNameFromJobName not consistent among different job types

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 2.5.0
    • 2.4.0
    • API, grouperLoader
    • None

    Description

      Hib3GrouperLoaderLog.getGroupNameFromJobName() assumes different parts of a job name are separated with two underscores. It throws a stacktrace on maintenance jobs.

      import edu.internet2.middleware.grouper.app.loader.db.Hib3GrouperLoaderLog
       
      jobs = [
        'CHANGE_LOG_changeLogTempToChangeLog',
        'CHANGE_LOG_consumer_grouperRules',
        'CHANGE_LOG_consumer_syncGroups',
        'LDAP_GROUPS_FROM_ATTRIBUTES__app:test:grp-1904-ldap__c894cd3152ee407788b2ac761b21e011',
        'LDAP_GROUP_LIST__app:test:grp-1904-ldap-grouplist__4197f023c67a4a56bc3bce3288dbf90e',
        'LDAP_SIMPLE__app:test:grp-1904-ldap-simple__d7157d1b8ca24188a644d3f453c72ca7',
        'MAINTENANCE__builtinMessagingDaemon',
        'MAINTENANCE__enabledDisabled',
        'MAINTENANCE__rules',
        'MAINTENANCE_cleanLogs',
        'OTHER_JOB_attestationDaemon',
        'OTHER_JOB_deprovisioningDaemon',
        'OTHER_JOB_findBadMemberships',
        'OTHER_JOB_grouperObjectTypeDaemon',
        'OTHER_JOB_schedulerCheckDaemon',
        'OTHER_JOB_tierInstrumentationDaemon',
        'SQL_GROUP_LIST__app:test:ehcache-test:etc:sampleGroupLoader__dcbaed4e27ce421ca9f7802e35fda9a6',
        'SQL_GROUP_LIST__app:test:grp-2244:grp-2244-job1__d69bfbb0a6354ac2b79b8d6a77c5e229',
        'SQL_GROUP_LIST__app:test:grp-2244:grp-2244-job2__cae67a1e66784da6abb2eb008809b99f',
        'SQL_GROUP_LIST__etc:loader:basis:depts__ab0645494ae3498aa8436f7a5fc1f2c1',
        'SQL_GROUP_LIST__etc:loader:basis:orgs__3779b51223804784b4a02ee238b73079',
        'SQL_GROUP_LIST__etc:loader:ref:job-categories__7fb2004727904b13bdf45fd217695bd9',
        'SQL_GROUP_LIST__etc:loader:ref:job-roles__095c803dd00d4122a72fb765108eab09',
        'SQL_GROUP_LIST__etc:loader:test20190708:loader-AF__95d0899e65e34ae2889825162fb5635f',
        'SQL_GROUP_LIST__etc:loader:test20190708:loader-FA__ca445704d2584c74aec4da2ae1c48844',
        'SQL_SIMPLE__app:test:csvSync__f4f22a6073c948a6a5159e55a3cb16e9',
        'SQL_SIMPLE__app:test:loopTest:looptest_loader__a34d14b6950b45ed9eb575237adb1d82',
      ]
       
      jobs.each {
          def job = new Hib3GrouperLoaderLog()
          job.setJobName(it)
          try {
              println "${it}\t${job.getGroupNameFromJobName()}"
          } catch (e) {
              println "${it}\t${e.message}"
          }
      }
      

      CHANGE_LOG_changeLogTempToChangeLog     String index out of range: -2
      CHANGE_LOG_consumer_grouperRules        String index out of range: -2
      CHANGE_LOG_consumer_syncGroups  String index out of range: -2
      LDAP_GROUPS_FROM_ATTRIBUTES__app:test:grp-1904-ldap__c894cd3152ee407788b2ac761b21e011   app:test:grp-1904-ldap
      LDAP_GROUP_LIST__app:test:grp-1904-ldap-grouplist__4197f023c67a4a56bc3bce3288dbf90e     app:test:grp-1904-ldap-grouplist
      LDAP_SIMPLE__app:test:grp-1904-ldap-simple__d7157d1b8ca24188a644d3f453c72ca7    app:test:grp-1904-ldap-simple
      MAINTENANCE__builtinMessagingDaemon     String index out of range: -2
      MAINTENANCE__enabledDisabled    String index out of range: -2
      MAINTENANCE__rules      String index out of range: -2
      MAINTENANCE_cleanLogs   String index out of range: -2
      OTHER_JOB_attestationDaemon     String index out of range: -2
      OTHER_JOB_deprovisioningDaemon  String index out of range: -2
      OTHER_JOB_findBadMemberships    String index out of range: -2
      OTHER_JOB_grouperObjectTypeDaemon       String index out of range: -2
      OTHER_JOB_schedulerCheckDaemon  String index out of range: -2
      OTHER_JOB_tierInstrumentationDaemon     String index out of range: -2
      SQL_GROUP_LIST__app:test:ehcache-test:etc:sampleGroupLoader__dcbaed4e27ce421ca9f7802e35fda9a6   app:test:ehcache-test:etc:sampleGroupLoader
      SQL_GROUP_LIST__app:test:grp-2244:grp-2244-job1__d69bfbb0a6354ac2b79b8d6a77c5e229       app:test:grp-2244:grp-2244-job1
      SQL_GROUP_LIST__app:test:grp-2244:grp-2244-job2__cae67a1e66784da6abb2eb008809b99f       app:test:grp-2244:grp-2244-job2
      SQL_GROUP_LIST__etc:loader:basis:depts__ab0645494ae3498aa8436f7a5fc1f2c1        etc:loader:basis:depts
      SQL_GROUP_LIST__etc:loader:basis:orgs__3779b51223804784b4a02ee238b73079 etc:loader:basis:orgs
      SQL_GROUP_LIST__etc:loader:ref:job-categories__7fb2004727904b13bdf45fd217695bd9 etc:loader:ref:job-categories
      SQL_GROUP_LIST__etc:loader:ref:job-roles__095c803dd00d4122a72fb765108eab09      etc:loader:ref:job-roles
      SQL_GROUP_LIST__etc:loader:test20190708:loader-AF__95d0899e65e34ae2889825162fb5635f     etc:loader:test20190708:loader-AF
      SQL_GROUP_LIST__etc:loader:test20190708:loader-FA__ca445704d2584c74aec4da2ae1c48844     etc:loader:test20190708:loader-FA
      SQL_SIMPLE__app:test:csvSync__f4f22a6073c948a6a5159e55a3cb16e9  app:test:csvSync
      SQL_SIMPLE__app:test:loopTest:looptest_loader__a34d14b6950b45ed9eb575237adb1d82 app:test:loopTest:looptest_loader
      

      Attachments

        Activity

          People

            chad.redman@at.internet2.edu Chad Redman (unc.edu)
            chad.redman@at.internet2.edu Chad Redman (unc.edu)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: