Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-4129

mail.smtp.grouperEmailContentType values not supported for "Grouper report" email ( and likely other standard emails)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • None
    • None

    Description

      When setting
      grouper.properties, mail.smtp.grouperEmailContentType = text/html; charset=utf-8 

      The daily "Grouper report" email ( and likely other standard emails) no longer wrap lines properly.

      https://github.com/Internet2/grouper/blob/GROUPER_2_6_BRANCH/grouper/src/grouper/edu/internet2/middleware/grouper/util/GrouperEmail.java

      Already has some "odd" logic trying to fix "line endings" based on the start of the body having "<HTML>", but it appears to be flawed / lacking.

      Perhaps the behavior should be controlled only based on  mail.smtp.grouperEmailContentType settings? ( if contains "text/html" then sub \r\n with "</br>"  instead of looking at the starting string of the body? )

      Or
      Do a more formal encoding assuming inputs are always "plain text" and need to be HTML escaped?

      Attachments

        Activity

          People

            chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
            carey.black.3@at.internet2.edu Carey Black
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: