Uploaded image for project: 'Shibboleth User Interface'
  1. Shibboleth User Interface
  2. SHIBUI-1249

Entity Attributes Filter: Invalid script produces 400, subsequent saves produce original error message

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • None
    • None
    • None
    • Sprint - Versions (12/5/2019)

    Description

      Tested in 1.5.0-SNAPSHOT-6c05a36 on http://shibboleth-ui.unicon.net/dashboard

      Description

      Steps
      Log into UI https://shibboleth-ui.unicon.net/
      Click 'Add New' button and select 'Metadata Provider’
      Choose a provider type that supports Entity Attributes filters (such as FileBackedHttpMetadataResolver)
      Create a basic provider
      Finish/Save the provider
      From the dashboard, on the provider just created, click 'Manage Filters'
      Click 'Add Filter'
      For filter type, choose 'EntityAttributes'
      Enter a 'Name'
      For 'Search By', choose 'Script'
      Enter any bogus script
      Attempt to save
      Note the 400 error
      Enter a valid script (something as simple as: true;)
      Attempt to save
      Note the same 400 error containing the old script
      Click Cancel
      Note that there are now two Entity Attributes Filters
      Edit each one, checking the script

      What is occurring
      Failed/bogus scripts produce a 400 but save anyway. Once this occurs, fixing the script and saving results in a duplicate Filter being created.

      What is expected
      No filter should be created until a script is successfully handled and a save completes properly.

      Attachments

        Activity

          People

            dmitriy.kopylenko@at.internet2.edu Dmitriy Kopylenko (unicon.net)
            WSmith Bill Smith (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 4 hours, 48 minutes
                4h 48m
                Remaining:
                Remaining Estimate - 4 hours, 48 minutes
                4h 48m
                Logged:
                Time Spent - Not Specified
                Not Specified